Open jessegreenberg opened 3 years ago
This was decided while working on https://github.com/phetsims/gravity-force-lab-basics/issues/303.
This would happen in utterance-queue now that SpeechSynthesisAnnouncer lives there.
Could we instead handle this by speaking this before turning it off? That would be in joist. I wonder if that would be nicer than another Property.
It is confusing that the voicingManager.enabledProperty can have a value of false but there can still be speech with
speakIgnoringEnabled
. A better way would be to provide a separate Property to control speech output while making it so that whenever voicingManager.enabledProperty is false there can be no speech. Here is some scratch illustrating the change we are thinking of.Likely related to https://github.com/phetsims/joist/issues/743 because that will determine where simVoicingEnabledProperty should live. COuld be on the AudioManager, but maybe it should be on a "PreferencesModel", whatever that ends up looking like.