search

phetsims / utterance-queue

Alerting library powered by aria-live
http://scenerystack.org/
MIT License
1 stars 2 forks source link

Voicing doesn't indicate changes to Pitch or Rate sliders #90

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Seen while testing https://github.com/phetsims/qa/issues/831 with mac + safari/chrome:

In the Audio tab of the Preferences menu when using keyboard nav to change the pitch or rate, Voicing doesn't utter anything. However, if I change the pitch/rate using the mouse, Voicing occurs. This was also seen with GFL:B on Master. This doesn't happen in the published version of GFL:B.

https://user-images.githubusercontent.com/87318828/187752238-f4b0a1e9-1e61-471d-ab23-c08713c8297a.mov

jessegreenberg commented 2 years ago

Thanks @Nancy-Salpepi Ill take a look. @zepumph fyi.

jessegreenberg commented 2 years ago

Hmm, odd - I notice that if I press the keyboard buttons slowly and wait ~1 second before releasing I do hear the responses. There must be some interruption happening.

jessegreenberg commented 2 years ago

@zepumph helped me think through this - There is a custom Property listener in these controls that trigger the Voicingresponses. We should try to use the code in AccessibleValueHandler to trigger voicing. This could also be an opportunity to add Voicing to Slider directly so that we get Voicing from its DragListener for mouse/touch input. voicingOnEndResponse is public from AccessibleValueHandler and is probably a good place to start.

jessegreenberg commented 2 years ago

Since it seems this will be resolved in preferences components or Slider and not utterance-queue, Ill pick up this issue in joist here: https://github.com/phetsims/joist/issues/854