search

phetsims / utterance-queue

Alerting library powered by aria-live
http://scenerystack.org/
MIT License
1 stars 2 forks source link

Voicing doesn't pronounce "close" correctly #91

Closed Nancy-Salpepi closed 2 years ago

Nancy-Salpepi commented 2 years ago

Seen while testing https://github.com/phetsims/qa/issues/831 but also present in GFL:B on master: The close button is pronounced as the opposite of far instead of the opposite of open.

This is seen with macOS 12.5.1 + safari/chrome. This doesn't happen with published JT or GFL:B.

Occurs with Alex voice in Safari (only voice currently working) and with all voice options on chrome.

jessegreenberg commented 2 years ago

I am going to take a look at this now. But since it came from https://github.com/phetsims/qa/issues/831, I wanted to notify @zepumph since this is related to RaP progress.

Nancy-Salpepi commented 2 years ago

It is also mispronounced in the keyboard shortcuts dialog

Screen Shot 2022-08-31 at 3 36 32 PM
jessegreenberg commented 2 years ago

Confirmed in macOS 11.6.2 Chrome 104.0.5112.101, with voice "Google US English", in RaP running off of master.

NOT seeing this happen in the published version of JT with voice "Alex".

But I AM seeing this happen in the published version of JT with voice "Google US English".

jessegreenberg commented 2 years ago

It is also mispronounced in the keyboard shortcuts dialog

That is surprising to me! It should have context in that phrase to find the right pronunciation.

Nancy-Salpepi commented 2 years ago

It is also mispronounced in the keyboard shortcuts dialog

I have seen it with "Alex" in safari and with the "Google US English" voice in chrome.

Nancy-Salpepi commented 2 years ago

The close button for the Updates and About dialogs is pronounced correctly (tested with safari + Alex) The keyboard preferences and Preferences dialog close buttons are where it is pronounced incorrectly as well as the statement mentioned above.

jessegreenberg commented 2 years ago

Yes, thanks @Nancy-Salpepi, I just confirmed that it is correct for the "Updates" dialog.

jessegreenberg commented 2 years ago

For the "Close" button, I see that our string pattern puts a period at the end of the response.

"Preferences, Close."

I thought the period may be forcing the pronunciation. The punctuation was added explicitly in https://github.com/phetsims/sun/commit/f8020e6c839f603b6a0ab171d8055a3bdc52e8b2.

I tried removing the period and it had no impact on the pronunciation. It still pronounces as /kloʊs/.

The reason it is happening on master and not in published versions is because the new string pattern "{{title}}, Close." was added after JT/GFL:B were published. The synth uses /kloʊs/ instead for that context.

I don't think there is anything for us to do here, pronunciation is generally out of our hands. But it was good to look into and worth checking that strings look clean.

I am going to notify Voicing team that this is happening and anyone can reopen if they feel this is worth more time.