Closed pixelzoom closed 5 years ago
Me in https://github.com/phetsims/vector-addition/issues/250#issuecomment-548104533:
Let's be sure we're all using "active vector" the same way. The active vector is the selected vector, and there can be at most one active vector. All vectors on the graph have the same pointer areas, regardless of whether they are active (selected) or inactive (unselected). So... @KatieWoe do you really mean "active vector" or do you mean any vector that's on the graph?
@KatieWoe in https://github.com/phetsims/vector-addition/issues/250#issuecomment-548106090
Either, the pointer area size doesn't differ, just any that is on the graph. I did notice a bit more with active vectors.
@KatieWoe said:
... I did notice a bit more with active vectors.
I'm not sure why that would be the case. Pointer areas for active and inactive vectors are identical. For example, 'a' is active, 'b' is inactive:
It was mostly because the Vector Value box would stop showing the values
I'm confused.... By "Vector Value box" do you mean "Vector Values accordion box"? And why would whether that shows values affect your ability to grab a vector?
Here are the current values for vector pointer areas in VectorAdditionConstants.js. The first pair of values is applied to the entire arrow and affects translation. The second pair of values is applied to the arrow head, and affects rotation and scaling.
// dilation of vector (arrow) pointer areas
VECTOR_TOUCH_AREA_DILATION: 3,
VECTOR_MOUSE_AREA_DILATION: 3,
// dilation of vector head pointer areas, for vectors that can be scales/rotated
VECTOR_HEAD_TOUCH_AREA_DILATION: 8,
VECTOR_HEAD_MOUSE_AREA_DILATION: 6,
Yes. I just meant that when I missed the active vector, the the Vector Values accordion box would show it immediately since it would stop showing the values. Sometimes I could miss it if I picked up the vector by sliding my finger, but the active vector was more obvious.
Assigning to @arouinfar to advise on how to proceed.
I've been testing quite a bit on my phone, and I do not have trouble translating the vectors or picking up the active vector. I think the trick is to grab the vector by its label, since that is also grabbable. I'll make a note of this in the Teacher Tips.
I am hesitant to dilate the touch areas any further because there could be spillover to neighboring vectors. Since the problem was reported for active vectors (which always have labels), I think this is safe to close.
For https://github.com/phetsims/QA/issues/445 and https://github.com/phetsims/QA/issues/446.
In https://github.com/phetsims/vector-addition/issues/250#issuecomment-548102879, @KatieWoe reported: