phetsims / vector-addition

“Vector Addition” is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 5 forks source link

trouble picking up vectors on the graph #263

Closed pixelzoom closed 5 years ago

pixelzoom commented 5 years ago

For https://github.com/phetsims/QA/issues/445 and https://github.com/phetsims/QA/issues/446.

In https://github.com/phetsims/vector-addition/issues/250#issuecomment-548102879, @KatieWoe reported:

I noticed in https://github.com/phetsims/QA/issues/445 that on iPad I honestly had a bit more trouble picking up active vectors on the graph. Not quite enough for its own issue, but @arouinfar might want to take a look.

pixelzoom commented 5 years ago

Me in https://github.com/phetsims/vector-addition/issues/250#issuecomment-548104533:

Let's be sure we're all using "active vector" the same way. The active vector is the selected vector, and there can be at most one active vector. All vectors on the graph have the same pointer areas, regardless of whether they are active (selected) or inactive (unselected). So... @KatieWoe do you really mean "active vector" or do you mean any vector that's on the graph?

@KatieWoe in https://github.com/phetsims/vector-addition/issues/250#issuecomment-548106090

Either, the pointer area size doesn't differ, just any that is on the graph. I did notice a bit more with active vectors.

pixelzoom commented 5 years ago

@KatieWoe said:

... I did notice a bit more with active vectors.

I'm not sure why that would be the case. Pointer areas for active and inactive vectors are identical. For example, 'a' is active, 'b' is inactive:

screenshot_1653
KatieWoe commented 5 years ago

It was mostly because the Vector Value box would stop showing the values

pixelzoom commented 5 years ago

I'm confused.... By "Vector Value box" do you mean "Vector Values accordion box"? And why would whether that shows values affect your ability to grab a vector?

pixelzoom commented 5 years ago

Here are the current values for vector pointer areas in VectorAdditionConstants.js. The first pair of values is applied to the entire arrow and affects translation. The second pair of values is applied to the arrow head, and affects rotation and scaling.

    // dilation of vector (arrow) pointer areas
    VECTOR_TOUCH_AREA_DILATION: 3,
    VECTOR_MOUSE_AREA_DILATION: 3,

    // dilation of vector head pointer areas, for vectors that can be scales/rotated
    VECTOR_HEAD_TOUCH_AREA_DILATION: 8,
    VECTOR_HEAD_MOUSE_AREA_DILATION: 6,
KatieWoe commented 5 years ago

Yes. I just meant that when I missed the active vector, the the Vector Values accordion box would show it immediately since it would stop showing the values. Sometimes I could miss it if I picked up the vector by sliding my finger, but the active vector was more obvious.

pixelzoom commented 5 years ago

Assigning to @arouinfar to advise on how to proceed.

arouinfar commented 5 years ago

I've been testing quite a bit on my phone, and I do not have trouble translating the vectors or picking up the active vector. I think the trick is to grab the vector by its label, since that is also grabbable. I'll make a note of this in the Teacher Tips.

I am hesitant to dilate the touch areas any further because there could be spillover to neighboring vectors. Since the problem was reported for active vectors (which always have labels), I think this is safe to close.