search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

bugs introduced into Scoreboard #11

Closed pixelzoom closed 10 years ago

pixelzoom commented 10 years ago

Commit https://github.com/phetsims/vegas/commit/4a2c21b0bf9e5ebba182953e4d116a42f733d39e changed 'New Game' to 'Start Over', but also introduced some problems.

(1) Default font size was changed from 20 to 16. Looks like this was done for the benefit of balancing-act. But it adversely affects graphing-lines, and potentially other sims. balancing-act should have used the options.font to set its preferred font size.

(2) Three documented options related to the 'Start Over' button are now being ignored. Those options are: startOverButtonColor: new Color( 235, 235, 235 ), startOverButtonXMargin: 20, startOverButtonYMargin: 5

pixelzoom commented 10 years ago

build-an-atom is the other sim affected by the font-size change. It's scoreboard font is noticeably smaller than published version 1.1.2.

pixelzoom commented 10 years ago

I took care of (2), the options that were being ignored.

For (1), I defensively set the font size to 20 in graphing lines.

Ressigning to @jbphet to decide what he wants to do about the font size in build-an-atom.

pixelzoom commented 10 years ago

Note that the default color for the 'Start Over' button was also changed. Is this desirable for all sims, or was it done for balancing-act? It affected both build-an-atom and graphing-lines.

jbphet commented 10 years ago

Changed the default font size back to 20, see be77758a944e62417ee6740c331252d207cac084.

jbphet commented 10 years ago

The color change was intentional, and resulted from review and iteration with @ariel-phet and @kathy-phet.

pixelzoom commented 10 years ago

@jbphet, is there anything left to be done on this?

jbphet commented 10 years ago

Don't think so. Closing.