search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

LevelSelectionButton.DEFAULT_BUTTON_DIMENSION is unused. #124

Closed pixelzoom closed 7 months ago

pixelzoom commented 7 months ago

In https://github.com/phetsims/vegas/commit/80a06c1d31d3cc320024756a7fe9f3641f6bf3a4 for https://github.com/phetsims/vegas/issues/120, @Luisav1 added this to LevelSelectionButton:

export const DEFAULT_BUTTON_DIMENSION = 150;

DEFAULT_BUTTON_DIMENSION is not used anywhere inside or outside of LevelSelectionButton, so I'm going to delete it.

For future reference... It you did need to add such a const, it would be preferrably to add it to class LevelSelectionButton as

public static readonly DEFAULT_BUTTON_DIMENSION = 150

.. instead of as an additional export.

pixelzoom commented 7 months ago

@Luisav1 please review, close if OK.

Luisav1 commented 7 months ago

@pixelzoom Oops, thanks! That sounds great, closing.