search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

Start Over button can overlap text with ?stringTest=dynamic #128

Closed Nancy-Salpepi closed 4 months ago

Nancy-Salpepi commented 4 months ago

Test device MacBook Air M1 chip

Operating System 14.4.1

Browser Safari 17.4.1

Problem description Seen during https://github.com/phetsims/qa/issues/1066 and https://github.com/phetsims/qa/issues/1067: If I make the screen smaller when the strings are long, the Start Over button will overlap the time.

Steps to reproduce

  1. In Graphing Lines or Graphing Slope-Intercept add ?stringTest=dynamic to the end of the url
  2. Go to any game level and press the right arrow key 3 times
  3. Grab the right side of the window and make the screen smaller

Visuals

https://github.com/phetsims/vegas/assets/87318828/39ee52db-2fc6-485a-aa31-b9543c8e4a9a

pixelzoom commented 4 months ago

At first I could not reproduce this. Then I realized that the time display needs to be enabled.

pixelzoom commented 4 months ago

Fixed in https://github.com/phetsims/vegas/commit/979da81155ac6a135e5d4773ea1d3750479636fe (maxWidth needed to be set dynamically). Cherry picked to graphing-lines 1.4 and graphing-slope-intercept 1.2.

@Nancy-Salpepi would you please verify in master? If it looks OK, you may close this issue. We'll verify for RC2 in https://github.com/phetsims/graphing-lines/issues/159.

Nancy-Salpepi commented 4 months ago

At first I could not reproduce this. Then I realized that the time display needs to be enabled.

Sorry about that!

All looks fixed in main. Closing.