search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

Aesthetic improvements for LevelCompletedNode #15

Closed samreid closed 10 years ago

samreid commented 10 years ago

LevelCompletedNode currently looks like so (in the vegas example html):

test

I think it would look better to left align Level/Score/Time and to remove the word "Your".

samreid commented 10 years ago

Here is an artist's rendition of some of the above suggestions. I don't feel too strongly about putting "new best" on the same line as the time, but thought I would get others' opinions.

after

This rendering is much easier to visually parse than the one in the issue description.

pixelzoom commented 10 years ago

I prefer center aligned. The whitespace looks more balanced, and will be more likely to look balanced for all locales.

No opinion on whether to remove "Your" from "Your New Best".

samreid commented 10 years ago

I don't feel very strongly about this, but would like to hear from @jbphet and @ariel-phet before we move on from the alignment issue.

jbphet commented 10 years ago

I prefer the look when center aligned.

As for removing "Your", the phrase is a holdover from the Java implementations, and was present in the original Build an Atom game. If I recall correctly, a concern was expressed that without the "Your", users might thing that it's the best time ever, like in the old arcade games. We wanted to make it clear that this wasn't a best ever sort of thing. So, though I appreciate the conciseness, IMO it should remain.

samreid commented 10 years ago

That is a good argument for keeping "your", thanks! Let's just hear from @ariel-phet about the layout before moving on.

ariel-phet commented 10 years ago

I just don't have a strong preference on the layout, seems like centered will work best for all locales

samreid commented 10 years ago

That is a good argument for keeping "your", thanks! Let's just hear from @ariel-phet about the layout before moving on.

Well, in a separate thread we are discussing changing "your" to "my" (https://github.com/phetsims/vegas/issues/21) but I think everything in this issue is resolved. Closing.