search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

I recommend cheering when showing the RewardNode if audio is enabled #16

Closed samreid closed 10 years ago

samreid commented 10 years ago

I recommend cheering when showing the RewardNode if audio is enabled.

Bonus points: let's record our team cheering for the audio clip.

pixelzoom commented 10 years ago

Cheering recorded at 6/15/14 PhET party, using multiple iPhones. Please let me know how you want the audio delivered. (file format, bit rate, VBR/constant, mono/stereo,...)

samreid commented 10 years ago

I added the audio above. I used this online service to convert the original CAF file to a WAV file: http://media.io/

Then I used GoldWave to clip the audio to the appropriate region, and exported as: cheer-22khz-24kbps-mono.ogg cheer-24khz-32kbps-mono.mp3

I originally tried lower frequencies and bitrates, but it sounded worse at anything less than 20kHz, but this sounded good to me (on my desktop speaker system).

I'm planning to integrate this into Fraction Matcher for evaluation, and we will probably have to discuss as a team whether this should be generally used for all our sims, or if anyone recommends audio edits.

samreid commented 10 years ago

Here's a sim that uses the cheering sound for purposes of evaluation: http://www.colorado.edu/physics/phet/dev/html/fraction-matcher/1.0.0-dev.22/fraction-matcher_en.html

ariel-phet commented 10 years ago

@arielphet approves

samreid commented 10 years ago

At today's meeting, the majority of PhET team members recommended using our audio cheering for games when a perfect score is achieved. I'm already applying that in Fraction Matcher as a prototype, (see https://github.com/phetsims/fraction-matcher/issues/63) but in vegas it should be generalized.

pixelzoom commented 10 years ago

@ariel-phet provided the following feedback on Graphing Lines 1.0.0-dev.10:

  1. I think the team was all for the "cheering" - has that not been generalized as part of the reward node?

I told him that no, it has not been adopted as the official 'perfect score' sound in vegas.

I also think that if we're going to replace vegas.gameOver-perfectScore with 'cheering', then we should also replace vegas.gameOver-imperfectScore with something stylistically similar. The perfect/imperfect scores currently compliment each other, and that will no longer be true if replace 'perfect' with cheering.

pixelzoom commented 10 years ago

Done, see also #23.