search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

Reword "Your New Best" to "My New Best"? #21

Closed samreid closed 10 years ago

samreid commented 10 years ago

In https://github.com/phetsims/acid-base-solutions/issues/122#issuecomment-46233452 @pixelzoom pointed out that we sometimes say "your" and sometimes "my". In my recollection, "my" is more prevalent. This issue is to decide what's best for the wording of the "your new best" / "my new best" dialog and apply it.

pixelzoom commented 10 years ago

See vegas.LevelCompletedNode for implementation.

There are 2 related vegas string:

"yourNewBest": "(Your New Best!)", "pattern.0yourBest": "(Your Best: {0})",

samreid commented 10 years ago

In the related issue (see above), @ariel-phet said:

[...] Sims seem to be traditionally in first person (my matches, my collection...)

ariel-phet commented 10 years ago

Ask Kathy....but I think "My New Best" would be more consistent

pixelzoom commented 10 years ago

At 6/19/14 meeting, we decided to leave this 'as is' - "Your Best".