search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

Scoreboard floats but Navbar doesn't #28

Closed samreid closed 6 years ago

samreid commented 10 years ago

As noted in: https://github.com/phetsims/graphing-lines/issues/38

In my opinion, it is odd that the navbar stays at the bottom of the screen but the gamebar floats into the middle of the screen. Why should this be asymmetric? Screenshot from my skinny Win8/Chrome:

asymmetric

pixelzoom commented 10 years ago

ScoreboardBar is agnostic wrt where it's located. That's up to the client. It can be at the top, bottom, constrained to the "safe" area. Etc. In the context of Graphing Lines, it was decided by the team that the bar should be at the top of the safe are, so that it doesn't get too disconnected from the game - as it would in iPad portrait orientation.

samreid commented 10 years ago

Perhaps one day (but not for GL) we'll need to add support so that the ScoreboardBar appears at the top of the screen and reduces the "safe" area for the game (as the navbar does).

pixelzoom commented 10 years ago

Labeling this as a 'design' issue. Regardless of the decision, I think that positioning should be kept out of the implementation of ScoreboardBar. If we decide on a 'standard' location, then we can provide vegas support to make it easy to position a ScoreboardBar at that standard location.

samreid commented 10 years ago

Agreed this implementation would not be within ScoreboardBar and that it is a design issue.

pixelzoom commented 6 years ago

We discussed this behavior as part of the design meeting noted in #66, and the consensus was that keeping the status bar close to the challenge (and not floating to the top of the window) was the most generally desirable approach. @jonathanolson was the lone dissenter. But I did add option floatToTop: false to StatusBar, the base type for all status bars. (Scoreboard is deprecated, replaced by FiniteStatusBar.) So if this asymmetry bothers you, it's now a matter of convincing the designers.

Closing.