search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

'cheering' sound continues after you've pressed the 'Continue' button #34

Closed pixelzoom closed 6 years ago

pixelzoom commented 10 years ago

In https://github.com/phetsims/balancing-chemical-equations/issues/92, @ycarpenterphet reported:

If you receive a perfect score on a level, the 'cheering' audio track plays to completion even if the user clicks Continue and returns to the level selection screen and starts the next level. It feels a bit odd that the cheering sound continues once you've left the feedback/completion screen, though this is really minor complaint.

GameAudioPlayer currently has no interface for stopping sounds, so I suspect that this is an issue with all sims that have game audio. And perhaps this is something that wasn't considered when the old perfect-score sound was replaced with the 'cheering' sound -- the cheering sound is longer. In any case.... Labeling this as a design issue, and PhET will need to decide what (if anything) to do about it.

pixelzoom commented 6 years ago

As we add more sound to sims, this complaint may come up more often. @jbphet is there a plan for handling this? Or can we continue to ignore it?

jbphet commented 6 years ago

I have never really liked the cheering sound and was out when the decision was made to use it to replace the other sound that signaled that a level was completed, see https://github.com/phetsims/vegas/issues/16. If we are having problems with the length of the cheering sound, let's revert to the original sound or re-record a shorter version.

jbphet commented 6 years ago

As we add more sound to sims, this complaint may come up more often.

Did we have complaints about the sound used before?

pixelzoom commented 6 years ago

@jbphet The more general issue is not related to any specific sound. The issue is that there may be cases where a sound is in progress, and the user switches to doing something else. Should the sound that was in progress be allowed to completed, or should it stop when the user switches to doing something else? If the sound should stop, does the new sonification work support that?

jbphet commented 6 years ago

Understood. The tambo library already has that capability. I could add it to vibe, but in this particular case it would cause the cheering to end very abruptly when the user continued, and in my opinion that would not be an improvement to the user experience. Other people may feel differently, which is why I think @ariel-phet should weigh in.

pixelzoom commented 6 years ago

Good to know that tambo supports this. And my opinion is that we should do nothing in the case of this specific issue (cheering sound), and close this issue as "won't fix".

jonathanolson commented 6 years ago

I don't have a personal preference here, as long as doing something like this in the future is supported (sounds like it is).

zepumph commented 6 years ago

It does seem like tambo is the way of the future.

pixelzoom commented 6 years ago

At dev meeting, let's decide whether to close this issue. My feeling is that this sound is unlikely to change. And if it does change, it will probably do so as part of some larger "sound design" issue.

pixelzoom commented 6 years ago

8/16/18 dev meeting: Consensus agreed with https://github.com/phetsims/vegas/issues/34#issuecomment-413621883, and we should close this issue. Assigning to @jbphet (he was absent) so that he's aware of this decision, please close after reviewing this comment.

jbphet commented 6 years ago

Thanks for the heads up, closing.