search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

"ding" sound needs refining #38

Closed pixelzoom closed 9 years ago

pixelzoom commented 9 years ago

@kathy-phet provided this feedback on RPAL 1.0.0-dev.13.

The correct sound "ding" in the new HTML5 version is quite a bit louder and "tin-ier" than the Java version, especially at the beginning of the sound it seems. The Java ding was more sort of soothing reassurance. I used both without changing the volume settings on my computer -- so they seem to be a bit different. Any thoughts there?

pixelzoom commented 9 years ago

The Java version (game/correctAnswer.wav) has a little less attack. Other than that, the sounds are virtually identical. Why not just convert the Java file to .mp3 and .ogg ?

jbphet commented 9 years ago

That's basically what I did (convert the Java file to .mp3 and .ogg). I just spent some time examining the files, and there is definitely something up with the .mp3 version of the ding. It has a bit of a spike at the beginning, and this is audible as a sort of "whack" sound. I'm not sure where it came from, since it doesn't appear to be present in the .wav version, which I thought was the origin of the .mp3 version. My guess is that the original .wav was used, I noticed the "whack", removed it (via audio editing tools) from the .wav version, and neglected to re-convert the .mp3 version. Will do so now.

jbphet commented 9 years ago

The .mp3 file has been re-created from the original .wav file (in the assets directory), the bit rate was lowered from 56kbps to 32kbps, some space was trimmed off the beginning and end, and the first portion was run through a high-pass filter. To my ear, this has resulted in a significantly more pleasant sound, especially through headphones.

I'll have a few people on the design team give it a listen and, if it works for them, I'll close this issue.

jbphet commented 9 years ago

@pixelzoom, @amanda-phet and @samreid have listened to the new sound and agree that it is an improvement. Waiting on a couple of others.

pixelzoom commented 9 years ago

If we were waiting on anyone else, 1+ month is long enough. Closing.