branch: fix-highlight - Githubissues

phetsims / vegas

Reusable game components for PhET simulations.

MIT License

1 stars 4 forks source link

branch: fix-highlight #42

Closed pixelzoom closed 9 years ago

pixelzoom commented 9 years ago

I search through issues and didn't see any mention of this branch. Looks like most (all?) of the commits are by @jbphet, so assigning to him. Please describe this branch, and what the plans are for it.

jbphet commented 9 years ago

This branch was created to fix an issue for Build an Atom 1.1 that couldn't be fixed through referencing the latest Vegas version due to changes in other dependencies. This branch needs to be retained because the SHA for Vegas that is used in the 1.1 version of BAA is on this branch.

pixelzoom commented 9 years ago

Yikes. For the future, let's try not to publish anything off of non-master branches of common repos.

jbphet commented 9 years ago

This probably won't be a super common scenario as the common code gets more stable, but I don't think we should rule out this approach in cases where a maintenance release is needed and the common code has evolved so much that it's impossible to update one dependency without having to pull in a whole bunch of other new (to the sim) stuff. Otherwise, it kind of defeats the purpose of a maintenance release.

I'll add this as a topic for the next developer meeting.

pixelzoom commented 9 years ago

Can we rename this branch to build-an-atom-1.1 ?

pixelzoom commented 9 years ago

Notes from 4/2/15 developer meeting:

Creating a branch in this type of situation is OK, but should be sort of a "last resort".
Name the branch based on the sim repo and release number that it's serving.
Create an issue like this one, documenting the branch.
OK to keep this type of branch around indefinitely.

jbphet commented 9 years ago

This branch has been renamed to "fix-for-build-an-atom-1.1.1", see #43 for additional information on this branch. Closing.