GameTimer doesn't increment elapsed time

[pixelzoom]

This is a bug that was introduced during the conversion from PropertySet to Property in https://github.com/phetsims/vegas/commit/6660bbb0c4c0bd9e942c2630eea48ffe1d7dd2e2 on 11/3/2016. It was noticed by @phet-steele in https://github.com/phetsims/graphing-slope-intercept/issues/12#event-1030792871 and affects all sims that use GameTimer, including:

area-builder arithmetic balancing-chemical-equations graphing-lines graphing-slope-intercept reactants-products-and-leftovers

The symptom is that the clock shown in the scoreboard will not increment.

[pixelzoom]

Conversion of both elapsedTimeProperty and isRunningProperty were handled incorrectly. Client code in the above sims that still reference elapsedTime and isRunning will need to be fixed.

@jbphet I'll be making changes to 2 of your sims: arithmetic and area-builder. If you've published either of these sims since 11/3/2016, they may contain this bug.

[phet-steele]

@pixelzoom I'm not actually seeing this problem in area-builder. I do see the problem everywhere else you mentioned.

[pixelzoom]

area-builder doesn't seem to show time anywhere in the user interface. But it's definitely a problem in the code.

[phet-steele]

[pixelzoom]

Ah, sorry, I hadn't turned the clock on when testing area-builder. Area Builder is very odd. It uses GameTimer, but QuizGameModel is a PropertySet with its own elapsedTime Property. (@jbphet)

NOTE: Discussed with @jbphet. Area Builder is using GameTimer only for formatting the time. So not affected by this bug.

[pixelzoom]

The good news is that none of these sims appears to have been published with this bug.

[pixelzoom]

I reviewed arithmetic with @jbphet. Running with ?autoAnswer allowed me to get to the "game completed" screen to verify that the time looks correct.

[pixelzoom]

@phet-steele could do a quick verification of these sims in master? Thanks.

• [x] arithmetic
• [x] balancing-chemical-equations
• [x] graphing-lines
• [x] graphing-slope-intercept
• [x] reactants-products-and-leftovers

[phet-steele]

Verified!