search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

where to locate the status bar in games? #64

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

@amanda-phet Area Model attaches its status bar to the top of the browser window, not to the top of the layout bounds. That's totally unlike any game that uses vegas game components (because @jonathanolson is not using a vegas component, but should be). Should Area Model change, or do vegas StatusBar and ScoreboardBar need additional options?

Comparison screenshots, all run with ?dev:

screenshot_548

screenshot_549

screenshot_550

screenshot_551

pixelzoom commented 6 years ago

My recollection is that we decided to keep the status/scoreboard bar at the top of the layout bounds so that it wouldn't get moved too far away from the area where the challenge is displayed. E.g.:

screenshot_552

jonathanolson commented 6 years ago

To me, it looks really weird when it gets separated. I'm curious what a typical aspect ratio (say, portrait on an iPad) would look like?

pixelzoom commented 6 years ago

I don't care either way. But I do care that we just implemented StatusBar and didn't get this input because Area Model isn't using vegas components. This and all of the other differences should have been addressed by modifying/enhancing vegas components, not by creating new one-offs.

jonathanolson commented 6 years ago

Is the new StatusBar going to be used in make-a-ten? Because its status bar stays on the top like area-model.

Since work is being done in vegas, it sounds like a great opportunity to get everything consistent (and I'm happy to help get make-a-ten/area-model/fractions/etc. in compliance and using all the components).

pixelzoom commented 6 years ago

Is the new StatusBar going to be used in make-a-ten? Because its status bar stays on the top like area-model.

Yes. Make A Ten motivated this new vegas work in early Feb, https://github.com/phetsims/make-a-ten/issues/279.

Keeping the status bar on top was not a requirement of the new vegas components. And we all agreed that some things might change with Make A Ten. This may be one of them.

pixelzoom commented 6 years ago

4/12/18 design meeting:

No consensus on whether to keep bar at top of layoutBounds or float to top of window (visibleBoundsProperty.value). So add an option to float bar to top of window. Default is false. This will be completed as part of https://github.com/phetsims/vegas/issues/66.

Closing.