status bar change requests

phetsims / vegas

Reusable game components for PhET simulations.

MIT License

1 stars 4 forks source link

status bar change requests #66

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

Change requests from 4/12/18 design meeting with @amanda-phet @arouinfar @kathy-phet @jonathanolson @ariel-phet:

[x] add a 4th score display, "Score: ⭐⭐⭐⭐" (decorate ScoreDisplayDiscreteStars)
[x] add scoreDisplay option to ScoreboardBar (old bar)
[x] factor out a common bar that is used by both ScoreboardBar and StatusBar
[x] possibly rename ScoreboardBar and StatusBar to indicate what type of game they are used for
[x] add an option for bar to float to the top of the window
[ ] ❌(moved to https://github.com/phetsims/vegas/issues/67) scale height of score display background in LevelSelectionButton
[ ] ❌(moved to https://github.com/phetsims/vegas/issues/67) add optional "{string} title" for a RichText title to LevelSelectionButton

I'll do the work, @jonathanolson will review.

pixelzoom commented 6 years ago

Making changes to ScoreboardBar (the bar for games with a finite number of challenges) is going to be a lot of work. It's so different from StatusBar. The API needs to change, and there are 5 sims that use it that must be updated.

@ariel-phet FYI, this is turning into a multi-day project.

pixelzoom commented 6 years ago

FYI, I don't have time to make LevelSelectionButton enhancements, so I've moved those requests to https://github.com/phetsims/vegas/issues/67. This issue will deal solely with status bar and score displays.

pixelzoom commented 6 years ago

The sims that need to be migrated from ScoreboardBar to FiniteStatusBar are listed below. This is not a straightforward change; the API has changed significantly to support new features requested by the design team, and to be more similar to InfiniteStatusBar.

My sims:

[x] balancing-chemical-equations, before=1.2.0-dev.2
[x] graphing-lines, before=1.3.0-dev.1
[x] reactants-products-and-leftovers, before=1.2.0-dev.4

@jbphet sims: (NOTE: moved to https://github.com/phetsims/vegas/issues/71)

[ ] balancing-act
[ ] build-an-atom

pixelzoom commented 6 years ago

@ariel-phet FYI... This was a huge amount of work, and is far from done. And as I pointed out when these changes were requested, this work was required solely because the old scoreboard displayed score as "Score: 4", and a design specified displaying the score as "Score: ⭐⭐⭐⭐" . This seems like a case where PhET should have been willing to make a design concession.

pixelzoom commented 6 years ago

I've converted my sims to FiniteStatusBar.

Remaining work, probably in this order:

[ ] @jonathanolson code review (moved to #70)
[ ] @jbphet convert his sims (moved to #71)
[ ] someone needs to instrument the score display (moved to #69)

pixelzoom commented 6 years ago

Remaining work has been moved to issues #69, #70, #71.

Code review in https://github.com/phetsims/vegas/issues/70.