replace LevelSelectionItemNode with LevelSelectionButton

phetsims / vegas

Reusable game components for PhET simulations.

MIT License

1 stars 4 forks source link

replace LevelSelectionItemNode with LevelSelectionButton #68

Closed pixelzoom closed 6 years ago

pixelzoom commented 6 years ago

LevelSelectionItemNode is deprecated per https://github.com/phetsims/vegas/issues/59. It should be replaced by LevelSelectionButton in the sims listed below. This is not a straightforward conversion, since the API has changed significantly to support new features requested by designers.

[x] area-builder @jbphet
[x] arithmetic @jbphet
[x] balancing-act @jbphet
[x] build-an-atom @jbphet
[x] balancing-chemical-equations @pixelzoom
[x] expression-exchange @jbphet
[x] fraction-matcher @jonathanolson
[x] graphing-lines @pixelzoom
[x] make-a-ten @jonathanolson
[x] reactants-products-and-leftovers @pixelzoom

Last person to convert a sim:

[x] delete LevelSelectionItemNode

pixelzoom commented 6 years ago

My sims have been converted to LevelSelectionButton.

Assigning this to other developers who are responsible for sims in the check list above.

pixelzoom commented 6 years ago

By the way... One of the things that made this very easy to test for my sims was the ?showAnswers query parameter that I've implemented for all games. If other sims had this, I might have converted some of the sims that I'm not responsible for. Without, it's just too much time.

pixelzoom commented 6 years ago

Labeled for developer meeting to make developers aware of this, and confirm with @ariel-phet that this is properly labeled as "chip away".

And do we want to create an issue for each sim, or handle this here? An issue for each sim probably has a better chance of getting seen/addressed when it's time to revisit the sim.

jbphet commented 6 years ago

I have converted all sims for which I and the responsible developer.

jonathanolson commented 6 years ago

Refactored out usages, deleted. Closing.