Closed pixelzoom closed 6 years ago
@phet-steele can you create a QA task (for yourself or someone else) to identify other sims with rewardnode where this issue is relevant?
@phet-steele The common-code implementation (VEGAS/RewardNode) is currently used only in Equality Explorer and the vegas demo application. Make A Ten has its own implementation (which should be replaced with VEGAS/RewardNode, see https://github.com/phetsims/make-a-ten/issues/279). Unknown whether other sims have a similar dialog. If they do, they are not using common code, and an issue should also be created to make them use VEGAS/RewardNode.
@amanda-phet identified a problem with the use of the reward dialog (RewardDialog)
(VEGAS/RewardNode) is currently used only in Equality Explorer and the vegas demo application. Make A Ten has its own implementation...
@amanda-phet @pixelzoom what am I looking for? Sims with relevant issues in RewardDialog, or RewardNode? Or both?
You're looking for sims that open a dialog that obscures the challenge solution. They will not use RewardDialog because it is a new component; they will have their own Dialog, or perhaps something that quacks like a Dialog (as in Make A Ten, where a Panel is used). RewardNode (objects falling behind the dialog) is afaik not implicated in this issue.
@pixelzoom @amanda-phet I went ahead and looked for both, hopefully I'm correct about most of this. I'm not too happy about the lack of RewardNode usage! 😄
I only looked at published sims, which excludes:
The following sims were also ignored. They have game-like designs, but are vastly different than anything else:
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
NO | NO | YES |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
YES | NO | YES |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
NO | NO | YES |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
NO | NO | YES |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
YES (but as BCERewardNode) | NO | YES |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
YES (but as BAARewardNode) | NO | YES |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
YES (but as EqualityExplorerRewardNode) | YES | NO |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
YES (but as EERewardNode) | NO | NO |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
YES | NO | YES |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
YES (but as GLRewardNode) | NO | YES (but as ResultsNode) |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
YES (but as MakeATenRewardNode) | NO | NO |
RewardNode | RewardDialog | LevelCompletedNode |
---|---|---|
YES (but as RPALRewardNode) | NO | YES (but as ResultsNode) |
To summarize for @amanda-phet...
There is "questionable" overlap in Equality Explorer (https://github.com/phetsims/equality-explorer/issues/104), Make A Ten (https://github.com/phetsims/make-a-ten/issues/284) and Arithmetic (https://github.com/phetsims/arithmetic/issues/183).
It is @amanda-phet's call on whether/how to address this.
This needs to be addressed on a per-sim basis (no common-code solution), and each sim that has this problem has an associated issue. So closing this issue.
In https://github.com/phetsims/equality-explorer/issues/104, @amanda-phet identified a problem with the use of the reward dialog (RewardDialog). When you reach a certain score, it opens immediately and obscures the challenge solution.
This problem was also discovered in Make A Ten, see https://github.com/phetsims/make-a-ten/issues/284.
Identify whether these are other sims that have this problem.