consider having a separate class for the falling items in RewardNode

phetsims / vegas

Reusable game components for PhET simulations.

MIT License

1 stars 4 forks source link

consider having a separate class for the falling items in RewardNode #79

Closed jbphet closed 4 years ago

jbphet commented 4 years ago

For https://github.com/phetsims/tasks/issues/1017.

While reviewing TODO items in the vegas repo, I found this one in RewardNode:

//TODO should we create a separate class for this?

The comment was originally added as a question for a reviewer by @samreid and later converted to a TODO item by @pixelzoom. Assigning to @samreid to address.

pixelzoom commented 4 years ago

Sounds like @jbphet meant to assign this to @samreid, so I'll do so.

The{ imageWrapper, x, y, speed } data structure is internal to RewardNode. And it has existed like this since 5/30/14 without requiring fixes or maintenance. So I don't see any "win" in converting it to a class.

samreid commented 4 years ago

Sounds reasonable to me, closing.