Closed pixelzoom closed 3 years ago
Done in the above commits. The most time-consuming part of this was having to rename options buttonXMargin
and buttonYMargin
to xMargin
and yMargin
respectively. I had to inspect a boatload of usages that were all related to AccordionBox, not LevelSelectionButton.
@jbphet would you mind reviewing this, since you're the original author?
Changes look good. I also tested the appearance of the buttons in build-an-atom, fraction-matcher, and balancing-chemical-equations and they looked fine. I played through one level of the game in both build-an-atom and fraction-matcher with the timer on to make sure level selection worked and that the time and score were displayed correctly. Everything worked fine. Thanks @pixelzoom.
While I was in here, I fixed up some non-ES6-style things like usages of var
and function
and did some other minor cleanup. These were minor and don't require review (in my opinion), so I'm closing.
Discovered while working on the Wave Game screen in Fourier.
LevelSelectionButton does not propagate its options to super (RectangularPushButton), so passing a tandem to it does not instrument it.