Closed pixelzoom closed 3 years ago
4/22/21 design meeting @arouinfar @kathy-phet @jbphet @jessegreenberg @pixelzoom
LevelSelectionButton might be thematically like radio buttons, where each one has a different pitch (increasing by level number). But note that there is currently no "button group" for LevelSelectionButton in vegas, so no way to programmatically assign/increment different pitches.
I would be nice to have default sounds for everything, but options to provide sim-specific sounds.
5/13/21 design meeting: @jbphet @arouinfar @kathy-phet @KatieWoe @pixelzoom
InfiniteStatusBar: would be nice to have a custom sound for "Back" (<-) button
RewardDialog: No changes to "cheering" sound. Probably can use standard button sounds, and standard sound for dialog close (X) button. So perhaps nothing specific to do here.
@jbphet noted that sound needs to be turned on in the vegas demo, he'll do that.
One of the things listed in @pixelzoom's original comment above was "close (X) button" for the reward dialog. This already has a general sound design, which was done for dialogs opening and closing, so I don't think any additional work is needed here.
@jbphet said:
... so I don't think any additional work is needed here.
Indeed. From our design-meeting notes in https://github.com/phetsims/vegas/issues/88#issuecomment-840832910:
RewardDialog: No changes to "cheering" sound. Probably can use standard button sounds, and standard sound for dialog close (X) button. So perhaps nothing specific to do here.
@Ashton-Morris is going to come up with some sounds to try out for the "Back" button on the status bar.
@Ashton-Morris - Below is a screenshot of this button to give you a little context. Its function is to return to the level selection screen from a screen where a game or quiz of some kind is going on.
Also, you can try it out in context in Fourier: Making Waves if you like. It's used in the "Waves Game" screen. See https://bayes.colorado.edu/dev/phettest/fourier-making-waves/fourier-making-waves_en.html?ea&brand=phet.
FYI, Fourier "feature complete" milestone has been moved to 8/24/21.
It looks like the Back button sound was completed in https://github.com/phetsims/scenery-phet/issues/677. Do we now have support for all of the vegas components used by Fourier?
If so... @jbphet please review in Fourier (master), then assign to @arouinfar for sign-off.
Reviewing will be easier if you run with ?showAnswers&showReward
, which will show the challenge answers, and show the reward dialog after every correct answer. See https://github.com/phetsims/special-ops/blob/master/doc/phetTeamMember.md for how to enable showAnswers
.
Reviewing will be easier if you run with ?showAnswers&showReward, which will show the challenge answers, and show the reward dialog after every correct answer. See https://github.com/phetsims/special-ops/blob/master/doc/phetTeamMember.md for how to enable showAnswers.
So that's how you use showAnswers
! I don't know how many times I've tried to use it and then convinced myself that it doesn't actually exist or I've misremembered the name. I would have never guessed to go poking around in special-ops to find it.
@Ashton-Morris - As the lead sound designer, can you please also take a listen to this and let us know if you have any major objections?
Reviewed this with the sound design team today, and we're good with it. Closing.
For phetsims/fourier-making-waves#54
fourier-making-waves needs UI sound design for the following vegas (game) components:
LevelSelectionButton InfiniteStatusBar - 1 'Back' button RewardDialog - 2 push buttons, close (X) button
All of these components can be demonstrated in the vegas demo application, available via phetmarks. You can also see them in the Fourier sim's Wave Game screen.
This is required for Fourier 1.0 release, with a feature-complete milestone of 6/30/21.
Assigning to @arouinfar and @kathy-phet to prioritize and assign.