search

phetsims / vegas

Reusable game components for PhET simulations.
MIT License
1 stars 4 forks source link

branch: sound-design #92

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

This branch contains changes related to https://github.com/phetsims/vegas/issues/89 (sound design for vegas buttons). This work was original commited to master, but created 2 probems: (1) the changes were buggy and were causing CT errors, and (2) it was blocking publication of sims. So I created this branch, then reverted the work in master.

You'll also need https://github.com/phetsims/scenery-phet/commit/437c015bd31ad9a8e32786ec474331613fbf6003, and change that was made to BackButton in scenery-phet. It was similarily buggy (see https://github.com/phetsims/vegas/issues/89#issuecomment-856015584) but I didn't think it was worth creating a scenery-phet branch.

jbphet commented 3 years ago

The fix that @samreid did to the buggy code that I'd introduced looks good, so this branch is not longer needed. I'll close the issue and delete the branch.