search

phetsims / vibe

Library for handling audio for PhET simulations. Provides cross-platform support and enables usage of base64 audio embedded in an HTML document.
MIT License
3 stars 3 forks source link

eliminate vibe-specific code in reportUnusedMedia.js #17

Closed pixelzoom closed 9 years ago

pixelzoom commented 9 years ago

I noticed this bit of vibe-specific code in the audio.js plugin:

      // The only exception is VIBE/empty.mp3 which doesn't require an ogg version (WHY?)
      if ( key !== 'VIBE/empty.mp3' ) {
        if ( endsWith( key, '.mp3' ) || endsWith( key, '.ogg' ) ) {
          key = key.substring( 0, key.length - 4 );
        }
      }

This should be fixed.

jbphet commented 9 years ago

Hmmm. I'm confused by this. I'm not seeing the code described in audio.js, and I scanned through the recent history and didn't see a place where it was removed. @pixelzoom - what am I missing?

samreid commented 9 years ago

Perhaps @pixelzoom was referring to code in the reportUnusedMedia.js file, which was removed by @samreid in https://github.com/phetsims/chipper/commit/78f10d9ab62821bce5415dfd6d33978f8f0a9e1b as part of https://github.com/phetsims/chipper/issues/261 Let's reassign to @pixelzoom and ask.

pixelzoom commented 9 years ago

Indeed, I meant reportUnusedMedia.js.

samreid commented 9 years ago

I think this was addressed in https://github.com/phetsims/chipper/issues/261, can we close this one?

pixelzoom commented 9 years ago

Yup.