search

phetsims / vibe

Library for handling audio for PhET simulations. Provides cross-platform support and enables usage of base64 audio embedded in an HTML document.
MIT License
3 stars 3 forks source link

replace explicit prototype assignment in Sound.js with inherit(Object,...) #26

Closed jbphet closed 8 years ago

jbphet commented 8 years ago

See https://github.com/phetsims/graphing-lines/issues/13 for original discussion on this pattern.

jbphet commented 8 years ago

Fixed, assigning to @jessegreenberg for review (since it's common code).

jessegreenberg commented 8 years ago

Replacement of direct prototype assignment looks good, and I like the simultaneous documentation reformat :+1: Closing.