search

phetsims / vibe

Library for handling audio for PhET simulations. Provides cross-platform support and enables usage of base64 audio embedded in an HTML document.
MIT License
3 stars 3 forks source link

Firefox is about to implement initial audio blocking, we should test that we handle it #37

Closed jbphet closed 5 years ago

jbphet commented 5 years ago

I just saw an article about Firefox starting to auto-block audio and video on web pages until the user interacts with the page. Hopefully, this will be handled by the code already in place to handle similar behaviors seen in Chrome and Safari, see https://github.com/phetsims/vibe/issues/32, but we should test to make sure.

There is a parallel issue in the tambo repo, see https://github.com/phetsims/tambo/issues/58.

jbphet commented 5 years ago

Assigning to @phet-steele at @ariel-phet's suggestion.

@phet-steele - Can you please get set up to test with the upcoming version of Firefox (which I believe is v66) and test the sims that use the vibe libary and make sure they work? Some examples are the game screens on Balancing Act and Build an Atom. The main screen of Plinko also has sound capability. As mentioned in the related tambo issue, please check on both Windows and Mac if possible and, if not, assign back to @ariel-phet for additional followup. Thanks.

phet-steele commented 5 years ago

Testing suggested sims on Windows 10 with FF 66.0b7: sound works.

However, there was a neat interaction with the dev tools. Opening dev tools for the first time mutes all sound. Closing the dev tools, then opening the dev tools a second time brings sound back. It will even play all the sound it "queued" when sound was muted. This cycle repeats on each successive opening/closing of the dev tool. Hopefully our users on FF don't use the dev tools often 😉.

EDIT: Mac behaves identically.

jbphet commented 5 years ago

Since sound will all be using tambo in the future, the fact that it works is sufficient. I'm not going to worry about the interaction with the dev tools and the vibe version of the sound library. I'll do some investigation of this for tambo. Closing.