search

phetsims / vibe

Library for handling audio for PhET simulations. Provides cross-platform support and enables usage of base64 audio embedded in an HTML document.
MIT License
3 stars 3 forks source link

sherpa/base64Binary.js is miscapitalized resulting in the ohms law sim not working on case sensitive filesystems #8

Closed olleicua closed 9 years ago

olleicua commented 10 years ago

steps to reproduce:

  1. git clone git@github.com:phetsims/ohms-law.git
  2. clone other dependencies
  3. open in a browser

error:

GET http://127.0.0.1:3000/PHET/sherpa/base64Binary.js 404 (Not Found)
samreid commented 10 years ago

Thanks @olleicua for pointing out this problem. I tried to fix it in the above commit but am currently on Windows and cannot easily verify case sensitive filesystem problems. Can you pull and let me know if this problem is resolved?

samreid commented 10 years ago

@pixelzoom can you pull and verify this fix?

pixelzoom commented 10 years ago

Mac OS X is apparently not case-sensitive. If I reintroduce the case problem and test, it happily loads the file. So you'll need to ask someone with a Linux system.

samreid commented 10 years ago

Good to know (I'm a bit surprised), thanks for testing that!

pixelzoom commented 9 years ago

@olleicua did this resolve the problem that you reported?

jbphet commented 9 years ago

Haven't heard anything back from @olleicua, and the dependency on base64binary has been removed so this shouldn't be an issue any longer. Closing.

olleicua commented 9 years ago

Sorry, our project isn't on the latest version of Phet. We just renamed the file and changed all of the references to it.