Closed samreid closed 1 year ago
It looks like this checklist has not been maintained by @samreid @arouinfar or @KatieWoe. I've started code review in https://github.com/phetsims/wave-interference/issues/259, and this issue is not providing info needed to complete that checklist. E.g., whether the sim is feature complete, whether performance signoff has occured, whether pointerAreas have been reviewed, behavior with stringTest
, ...
I was unaware of this. QA section updated.
The checklist is now up to date, but reflects the progress for the screens which will be included in the 1.0 release. Leaving assigned to @ariel-phet to add a section for the 2.0 release.
Code review completed today, see #259, so I checked it off here in the master checklist.
@ariel-phet the remaining items are yours. We also need an additional, pared-down checklist for 2.0.
@arouinfar or @ariel-phet any other pre-publication items to do before I publish wave-interference 2.0? I noticed that the screenshot in the branch already shows the diffraction screen: https://github.com/phetsims/wave-interference/blob/7ebcb1ae70106ca93d7d430d4a6cf77f23a0fa3b/assets/wave-interference-screenshot.png
@samreid I don't think there's anything blocking 2.0.
I will make a 2.0 section of the checklist covering the design issues as I make the sim live. We should probably do the same for Implementation and QA too.
@samreid I don't think there's anything blocking 1.0.
I presume you meant there's nothing blocking today's publication of 2.0. Please correct me if this is wrong.
@samreid sorry, yes, I meant 2.0. 🤦♀
I've edited the comment.
Wave Interference 2.0 is published, @arouinfar can you please address post-publication steps?
The remaining unchecked items are not applicable (e.g. post-mortem, PhET-iO discussion), so this can be closed.
Wave Interference Port Master Checklist
Design
Implementation
grunt unpublished-readme
grunt published-readme
(in master and release branch)QA
Wave Interference 2.0
Design
Implementation
QA