search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
19 stars 5 forks source link

Pointer area for wavelength slider smaller than pointer area for other sliders in the sim #442

Closed loganbraywork closed 5 years ago

loganbraywork commented 5 years ago

Test device Windows 7 Laptop Operating System Windows 7 Professional v. 6.1 Browser Chrome Problem description From https://github.com/phetsims/QA/issues/424

The sliders for wavelength on the diffraction screen have a smaller pointer area than that which is found on other sliders in the simulation. Steps to reproduce

  1. Enter query ?showPointerAreas into the sim url
  2. Enter the "Diffraction" screen Visuals 2019-9-5PointerAreaWavInterf

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Wave Interference‬ URL: https://phet-dev.colorado.edu/html/wave-interference/2.0.0-rc.2/phet/wave-interference_all_phet.html?showPointerAreas Version: 2.0.0-rc.2 2019-09-04 01:17:25 UTC Features missing: touch User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36 Language: en-US Window: 1366x576 Pixel Ratio: 1/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 32 varying: 32 uniform: 256 Texture: size: 8192 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 8192x8192 OES_texture_float: true Dependencies JSON: {}

arouinfar commented 5 years ago

Good find @loganbraywork.

@samreid can you horizontally dilate the Wavelength tweakers, as was done for other NumberControls.

samreid commented 5 years ago

Some notes as I investigate this:

  1. This only affects Wave Interference and would not require a new RC for Waves Intro
  2. I made an overlay of the touch areas, and the large one is about 15-20% larger

image

samreid commented 5 years ago

If we use the same dimensions (horizontal and vertical) as the other number controls, it impinges somewhat on the slider track:

image

samreid commented 5 years ago

I factored out the horizontal part, and reduced the vertical part and now it looks like this:

image

I'll commit to master.

samreid commented 5 years ago

This is fixed in master, if/when we cherry pick it to the RC branch, it will require 2 cherry-picks.

KatieWoe commented 5 years ago

Looks good in the new rc