search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
19 stars 5 forks source link

Intensity window expands #444

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Test device Dell Operating System Win 10 Browser Chrome Problem description For https://github.com/phetsims/QA/issues/424 When strings are long, the intensity graph in the light screens expands and makes the page look cramped. Occurs in published version.

Visuals seemsclose

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: 12345678901234567890123456789012345678901234567890 URL: https://phet-dev.colorado.edu/html/wave-interference/2.0.0-rc.2/phet/wave-interference_all_phet.html?stringTest=long Version: 2.0.0-rc.2 2019-09-04 01:17:25 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.132 Safari/537.36 Language: en-US Window: 1536x722 Pixel Ratio: 2.5/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {}
arouinfar commented 5 years ago

Thanks @KatieWoe.

@samreid looks like the layout issues would be resolved if the Intensity panel didn't expand.

samreid commented 5 years ago

This will likely be solved by reducing the maxWidth on the intensity panel text. I also noted that with stringTest=double, it isn't quite long enough to be a problem:

image

samreid commented 5 years ago

Fixed and ready for cherry pick.

KatieWoe commented 5 years ago

Looks good in the new rc