search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
19 stars 5 forks source link

should ToolboxPanel use allowTouchSnag:true ? #455

Closed pixelzoom closed 5 years ago

pixelzoom commented 5 years ago

While working on https://github.com/phetsims/scenery/issues/999, I noticed that ToolboxPanel is the only client of DragListener.createForwardingListener that is using allowTouchSnag: false. In that issue, we changed the default to allowTouchSnag: true, and I changed ToolboxPanel accordingly to:

    node.addInputListener( DragListener.createForwardingListener( forwardingListener, {
      allowTouchSnag: false
    } ) );

I'm guessing that this was an oversight, because ToolboxPanel is similar to other UI components that use allowTouchSnag: true. If it's not an oversight, please document why allowTouchSnag: false is appropriate in this case.

samreid commented 5 years ago

Fixed, closing.