search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
18 stars 5 forks source link

CT testing not finishing #491

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago

In Wave Interference and Wave Intro a portion of the automated tests seem like they aren't being done. notdone notdoneintro

jonathanolson commented 4 years ago

It's a sim-specific failure, the import import buttonSound from '../../../sounds/squishier-button-007_mp3.js'; in WaveGeneratorNode (in wave-interference) doesn't seem to point to anything that I see existing.

For some reason... the build is failing, but not returning an error code. Investigating that (which is why this wasn't a "loud" failure)

jonathanolson commented 4 years ago

Committed a change to make sure these fail loudly. Unassigning myself.

samreid commented 4 years ago

Thanks @jonathanolson!

samreid commented 4 years ago

Tests are finishing now, closing.