search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
19 stars 5 forks source link

User reported issue: increase graph trace contrast #498

Open oliver-phet opened 4 years ago

oliver-phet commented 4 years ago

This was reported into phethelp by a Linux user and was likely caused by a graphics issue on their machine. However, I thought it would be best to get it recorded so that if/when this sim is revisited we could investigate increasing the contrast or modifying the colors of the probes/traces.

I see the dark trace, but the "light trace" is invisible, as is the grid that underlies the traces. The only evidence of the light trace on my computer is that in the places where it crosses the dark trace the dark trace has a small "gap" like you erased it with a pencil. My first thought in running the sim was that the light trace did not exist, I only noticed it did exist when I wanted to report the error and brought up the "report a problem" box. This seems to have changed the look-up table on my display so that the light trace became visible.

It is possible that your color scheme is just a little bit too subtle. Maybe your dark trace should be black 100% (I am guessing it's black 60% or so now) while your light should be black 40% (I am guessing it's black 10 or 20% now). Or let them be blue and red or something ...

image1

arouinfar commented 4 years ago

@samreid can you move this issue to wave-interference?

This request is similar to https://github.com/phetsims/wave-interference/issues/494:

I captured a video with the simulation wave-interference. Unfortunately, I could not see the light gray plot in the wave meter because there is not enough contrast between the background (white) and the plot (light grey). I would prefer colors like red and dark grey for the meters and the plots. I think this could also be an issue when you are using this simulation with a projector.

Let's darken the colors to:

const SERIES_1_COLOR = '#191919';
const SERIES_2_COLOR = '#808080';

image image

samreid commented 4 years ago

@arouinfar thanks for providing the code for this! Committed and pushed, can you please double check? Close if all is well.

arouinfar commented 4 years ago

Looks good in master @samreid, thanks!

samreid commented 4 years ago

Thanks, I'll leave this open and on-hold as a reminder that after publication @oliver-phet can notify the client.