phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
18 stars 5 forks source link

Suggestion for keyboard nav order #504

Open KatieWoe opened 3 years ago

KatieWoe commented 3 years ago

Test device Lovelace Operating System ChromeOS Browser Chrome Problem description For https://github.com/phetsims/QA/issues/511 If using keyboard nav, you pass through a number of options on the panel when going between the on/off for the wave source and the continuous/pulse options. This makes sense in regards to where everything is on the screen. However, since switching turns off the current wave, and after a switch between continuous and pulse the first thing a user is likely to want is to turn on the source, I'm wondering if they should be closer in the nav order. Minor issue.

Visuals Screen Shot 2020-10-27 at 3 18 57 PM

samreid commented 3 years ago

@emily-phet can you please comment on this, or assign someone accordingly?

arouinfar commented 3 years ago

Thanks for the suggestion @KatieWoe. There hasn't been much keyboard navigation design in this sim, and what's currently implemented is incomplete (toolbox/tools are not keyboard accessible). The continuous/pulse radio group is a secondary control, and I don't think I would move it up in the focus order. However, we could consider creating a custom keyboard shortcut to turn the source on/off.

I'd recommend marking this issue as on-hold or deferred until we get back to the keyboard navigation design, but I'll leave that up to @emily-phet.

emily-phet commented 3 years ago

Let's consider this when full keyboard navigation is implemented.