search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
18 stars 5 forks source link

TimeControlNode changes? #506

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

From https://github.com/phetsims/QA/issues/572#issuecomment-719880346. It's unlikely that this is related to sun button changes, and more likely related to changes to TimeControlNode.

@ariel-phet noted that TimeControlNode layout and sizing differs between published and master. If this is a know (or acceptable) regression, that's fine.

Wave Interference published (2.0.2): WI-published

Wave Interference master: WI-mater

@ariel-phet said:

As you can see the spacing between the play and step button has changed, and the radio buttons have grown a bit larger in comparison to the text, to my eye the step button is also slightly smaller. Not sure if some of this is sim specific or not

The change in "look" of disabled buttons is OK for now. It's due to sun buttons now using opacity instead of grayscale to denote "disabled".

samreid commented 3 years ago

This change is likely due to conversion to use TimeControlNode (and its defaults). That seems reasonable to me, but please reopen if changes are recommended.