phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
18 stars 5 forks source link

You can pause the continuous speaker membrane at any position, and when you resume playing, it may not trigger a sound depending on the membrane position. #512

Open samreid opened 3 years ago

samreid commented 3 years ago

Discovered in https://github.com/phetsims/wave-interference/issues/510, you can pause the continuous speaker membrane at any position, and when you resume playing, it may not trigger a sound depending on the membrane position.

samreid commented 3 years ago

In https://github.com/phetsims/wave-interference/issues/510#issuecomment-758184046 @KatieWoe said:

I think I saw what @samreid mentioned in https://github.com/phetsims/wave-interference/issues/510#issuecomment-758158006. If you stop a wave at as the sound starts, it can mess up the sound when it starts at a new frequency. I have had the wrong frequency start then fix itself, or the sound take a fair amount of time to start. https://drive.google.com/file/d/1N7DIgNoMb2OKR13YHVgrcMhqMSXopjN4/view?usp=sharing

KatieWoe commented 3 years ago

I just noticed that this seems to happen in https://github.com/phetsims/QA/issues/580, so it is unlikely to be related to the fix for #510

samreid commented 3 years ago

This does not feel blocking to me, @arouinfar what do you recommend?

arouinfar commented 3 years ago

Nice find! @samreid I would agree that this is not blocking. At worst, the speaker membrane sound is missing/off for one round which doesn't seem particularly serious to me.