search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
19 stars 5 forks source link

Value for MIN_INTER_CLICK_TIME #522

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

In WaveInterferenceSlider.js:

const MIN_INTER_CLICK_TIME = ( 1 / 60 * 1000 ) * 2; // min time between clicking sounds, in milliseconds, empirically determined

Consider reducing this to a value. Or at least explain the 4 magic numbers that you're using.

samreid commented 3 years ago

I simplified the constants, closing.