Closed pixelzoom closed 2 years ago
Today, STROBE said they would like this in the Wave Interference sim, too. Can we maintenance release with this new wording? And what does this wording look like on the website?
We gratefully acknowledge support from STROBE NSF Science & Technology Center Grant DMR-1548924. Any opinions, findings, and conclusions or recommendations expressed in this material are those of the author(s) and do not necessarily reflect the views of the National Science Foundation.
The published versions of both Waves Intro 1.1.3 and Wave Interference 2.0.4 currently have this text in the about dialogs:
This material is based upon work supported by the National Science Foundation under STROBE Grant No. DMR 1548924. Any opinions, findings, and conclusions or recommendations expressed in this material are those of the author(s) and do not necessarily reflect the views of the National Science Foundation.
Here is a visual diff with the proposed text:
Please confirm that we would like to make a maintenance release of both Waves Intro and Wave Interference with the wording change from:
This material is based upon work supported by the National Science Foundation under STROBE Grant No. DMR 1548924.
to
We gratefully acknowledge support from STROBE NSF Science & Technology Center Grant DMR-1548924.
I would estimate maintenance releasing this text change in both sims would take around an hour if nothing goes wrong. I'm asking for confirmation/approval before I work on maintenance release to make sure the change is worth the time (and since it was unclear whether it was known there was already attribution in Wave Interference).
I do not know how this information can be put on the sim pages. @arouinfar can you comment on that part?
Today, we adjusted the wording to this:
We gratefully acknowledge support from STROBE NSF Science & Technology Center Grant DMR-1548924. Any opinions, findings, and conclusions or recommendations expressed in this material are those of the authors and do not necessarily reflect the views of the National Science Foundation.
Removed () from authors.
I fixed it in master, but the shas are too old to cherry pick automatically (merge conflicts), so I'll do manual commits instead.
Wave Interference RC being built at https://phet-dev.colorado.edu/html/wave-interference/2.0.5-rc.1/phet/wave-interference_en_phet.html
Waves Intro RC being built at https://phet-dev.colorado.edu/html/waves-intro/1.1.4-rc.1/phet/waves-intro_en_phet.html
@arouinfar can you please spot check the RCs above before we make a production release?
I elaborated in slack:
I published RCs for Wave Interference and Waves Intro. The only intentional change is the credits thanks, but they were kind of old sims and would be good to check through them briefly. Can you please do a spot check for https://github.com/phetsims/wave-interference/issues/525 ? After you sign off I can publish.
@samreid looks good in the RC's.
Deployed: https://phet.colorado.edu/sims/html/waves-intro/latest/waves-intro_en.html
Please wait for the build-server to complete the deployment, and then test!
After testing, let the simulation lead know it has been deployed, so they can edit metadata on the website
Updating master README
info: git add README.md on waves-intro
info: git commit on waves-intro with message:
Generated published README.md as part of a production deploy for 1.1.4
Production README is already up-to-date
Deployed: https://phet.colorado.edu/sims/html/wave-interference/latest/wave-interference_en.html
Please wait for the build-server to complete the deployment, and then test!
After testing, let the simulation lead know it has been deployed, so they can edit metadata on the website
Updating master README
info: git add README.md on wave-interference
info: git commit on wave-interference with message:
Generated published README.md as part of a production deploy for 2.0.5
Production README is already up-to-date
Both production versions published, over to @arouinfar for next steps. In all, this process took about 65 minutes.
This was blocked by a character limit in the "Thanks to" field, but it was expanded in https://github.com/phetsims/website/issues/1280. The full text is now up on the wave-interference and waves-intro sim pages.
In https://github.com/phetsims/fourier-making-waves/issues/208#issuecomment-942776878, @kathy-phet said: