search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
18 stars 5 forks source link

Integrate sound generation that is now supported by Slider #528

Open jbphet opened 2 years ago

jbphet commented 2 years ago

In https://github.com/phetsims/sun/issues/697, generalized support for sound generation by sliders was added. The time was not taken to integrate this into all sims that were doing customized sound generation related to sliders, such as this one. Instead, the default sound was simply turned off via the options. Before this sin is released again off of master, we should consider integrating the now supported method slider sound generation.

jbphet commented 2 years ago

This has been implemented. Assigning to @samreid to review the behavior and implementation for both wave-interference and waves-intro.