search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
18 stars 5 forks source link

Sound files have both .js and .ts checked in. #530

Closed pixelzoom closed 2 years ago

pixelzoom commented 2 years ago

I see both .ts and .js for many sound files checked in for wave-interference. It’s causing transpile.js --watch to thrash a bit every time it starts, see below. Looks like this problem was introduced on 8/28/2022 for https://github.com/phetsims/wave-interference/issues/529.

% node js/scripts/transpile.js --watch
Clean stale chipper/dist/js files finished in 787ms
10:41:08 AM, 313 ms: ../wave-interference/sounds/etherealFluteForMeterLoop_mp3.js
10:41:08 AM, 28 ms: ../wave-interference/sounds/etherealFluteForMeterLoop_mp3.ts
10:41:08 AM, 27 ms: ../wave-interference/sounds/lightBeamLoopV5EqOutBass_mp3.js
10:41:08 AM, 26 ms: ../wave-interference/sounds/lightBeamLoopV5EqOutBass_mp3.ts
10:41:08 AM, 34 ms: ../wave-interference/sounds/organForMeterLoop_mp3.js
10:41:08 AM, 21 ms: ../wave-interference/sounds/organForMeterLoop_mp3.ts
10:41:08 AM, 24 ms: ../wave-interference/sounds/organV2ForMeterLoop_mp3.js
10:41:08 AM, 21 ms: ../wave-interference/sounds/organV2ForMeterLoop_mp3.ts
10:41:08 AM, 22 ms: ../wave-interference/sounds/sliderClickV2Left_mp3.js
10:41:08 AM, 21 ms: ../wave-interference/sounds/sliderClickV2Left_mp3.ts
10:41:08 AM, 25 ms: ../wave-interference/sounds/sliderClickV2Right_mp3.js
10:41:08 AM, 18 ms: ../wave-interference/sounds/sliderClickV2Right_mp3.ts
10:41:08 AM, 19 ms: ../wave-interference/sounds/sliderClicksIdeaCExampleLeft_mp3.js
10:41:08 AM, 19 ms: ../wave-interference/sounds/sliderClicksIdeaCExampleLeft_mp3.ts
10:41:08 AM, 19 ms: ../wave-interference/sounds/speakerPulseV4_mp3.js
10:41:08 AM, 18 ms: ../wave-interference/sounds/speakerPulseV4_mp3.ts
10:41:08 AM, 18 ms: ../wave-interference/sounds/squishierButtonV3_007_mp3.js
10:41:08 AM, 18 ms: ../wave-interference/sounds/squishierButtonV3_007_mp3.ts
10:41:08 AM, 19 ms: ../wave-interference/sounds/waterDropV5_001_mp3.js
10:41:08 AM, 17 ms: ../wave-interference/sounds/waterDropV5_001_mp3.ts
10:41:08 AM, 17 ms: ../wave-interference/sounds/waterDropV5_002_mp3.js
10:41:08 AM, 17 ms: ../wave-interference/sounds/waterDropV5_002_mp3.ts
10:41:08 AM, 17 ms: ../wave-interference/sounds/waterDropV5_003_mp3.js
10:41:08 AM, 16 ms: ../wave-interference/sounds/waterDropV5_003_mp3.ts
10:41:08 AM, 17 ms: ../wave-interference/sounds/waterDropV5_mp3.js
10:41:08 AM, 16 ms: ../wave-interference/sounds/waterDropV5_mp3.ts
10:41:08 AM, 21 ms: ../wave-interference/sounds/waveMeterSawTone_mp3.js
10:41:08 AM, 18 ms: ../wave-interference/sounds/waveMeterSawTone_mp3.ts
10:41:08 AM, 19 ms: ../wave-interference/sounds/waveMeterSmoothTone_mp3.js
10:41:08 AM, 21 ms: ../wave-interference/sounds/waveMeterSmoothTone_mp3.ts
Finished initial transpilation in 5413ms
samreid commented 2 years ago

Thanks, good catch! I deleted the *.js versions. I don't think tracking that history in these derived data files is important. Closing.