search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

Off-color yellow background behind string #1

Closed jonathanolson closed 10 years ago

jonathanolson commented 11 years ago

There is a rectangle of rgb(255,255,183) behind the string, whereas the sim's background is rgb(255,249,186). It seems to be "TheStringNodeRect", but there is not documentation for that rectangle. I don't know why it is there, and commenting out where it is added doesn't seem to affect the sim in any negative way.

Is there a purpose for this, or can it be removed?

woas-different-yellow

mlearner1 commented 10 years ago

If one take an image from Technical Design and put it in graphics editor (such as Paint), one can find that background color is (255,255,183) image

Could you double check if the background color should be (255,249,186)?

jonathanolson commented 10 years ago

The original sim's background color is #ffffb7 (255,255,183), so we should use that for all of the background. The extra rectangle around the string looks like it was unintentionally created in the design document when editing, and should be ignored.