search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

change WOAS to WAVE_ON_A_STRING #103

Closed pixelzoom closed 9 years ago

pixelzoom commented 9 years ago

There's no reason that this sim should be using a different convention, and it's resulting in WOAS-specific code in the string.js plugin (see https://github.com/phetsims/chipper/issues/83). Please change WOAS to WAVE_ON_A_STRING throughout.

pixelzoom commented 9 years ago

This should be a simple matter of changing 'WOAS' to 'WAVE_ON_A_STRING' in wave-on-a-string-config.js, then doing a global replace of 'WOAS/' with 'WAVE_ON_A_STRING/'. But when I do that, I get requirejs errors, e.g. this one in wave-on-a-string-main.js:

Uncaught Error: Script error for: WAVE_ON_A_STRING/view/WOASScreen http://requirejs.org/docs/errors.html#scripterror

So perhaps there's some more cleverness going on here. If that's the case, all the more reason to change this.

pixelzoom commented 9 years ago

Must've been a browser caching issue. I made the changes, cleared cache, and restarted the browser. Then WAVE_ON_A_STRING works fine with no errors. Assigning to @jonathanolson for review.

ariel-phet commented 9 years ago

This sim is published, and no further issues reported, closing