search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

branch: ruler-picker-updates #107

Open dubson opened 9 years ago

dubson commented 9 years ago

Modifying WOAS to improve appearance of rulers and pickers. For AP's approval.

dubson commented 9 years ago

I wish to alter the appearance of the rulers and pickers on WOAS. In preparing sim primer, I find the need for minor changes. I have conferred with KP and JO already, and have their approval. I have prepared a dev version of WOAS with the changes (1.0.1). The changes are: 1) rulers are now in front (not behind) so you can see the tic mark when you are measuring distance. 2) rulers have tic marks every 1 mm ( not every 2mm) for more precise measurements 3) rulers are somewhat more narrow (so not so heavy-looking) 4) rulers are partially transparent, so can see through 5) pickers on sliders are somewhat smaller, so not so heavy looking. Await comments/approval from AP.

ariel-phet commented 9 years ago

Changes look great to me. We of course should get the sim tested before releasing this version.

dubson commented 9 years ago

Ok, thanks!!

pixelzoom commented 8 years ago

Looks like @ariel-phet approved the changes. Have they been merged back into master? Can this branch be deleted? If not, what are the plans for this branch?

ariel-phet commented 8 years ago

@pixelzoom - since @dubson was planning to use this version for the sim primer, I assume the plan would be to make this the main version to test when we deploy

pixelzoom commented 8 years ago

@ariel-phet wrote:

I assume the plan would be to make this the main version to test when we deploy

We do not deploy out of branches like this, we deploy by branching master. Do you mean that the plan in to merge these changes into master?