search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

Reduce size of radio buttons to more consistent with other sims #113

Closed ariel-phet closed 8 years ago

ariel-phet commented 8 years ago

The radio buttons in WOAS are quite large, it would be good to reduce them to proportions that better match our more modern conventions.

See for instance http://phet.colorado.edu/sims/html/beers-law-lab/latest/beers-law-lab_en.html

I think a good "rule of thumb" is to make the diameter of the radio button match the height of the first capital letter in the label. For instance the "M" in "Manual"

ariel-phet commented 8 years ago

@jonathanolson if this is a fix that is very quick and would require minimal testing (I know the RC is already out) I would like to see this one pixel polish for this release. If not, please mark as priority deferred

jonathanolson commented 8 years ago

@ariel-phet, can you test on phettest to see if the appearance looks good?

I agree that it would need minimal testing, and I can move the change over to the RC when it looks good.

ariel-phet commented 8 years ago

Yes much better @jonathanolson, please move to RC and then close this issue.

jonathanolson commented 8 years ago

please move to RC

To the branch, or want rc-2?

ariel-phet commented 8 years ago

Your call...I don't believe we need an rc-2 unless any blocking issues are found.

jonathanolson commented 8 years ago

Moved commit to RC branch, closing.