search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

sim relies on align:'right' default for Panels #118

Closed pixelzoom closed 7 years ago

pixelzoom commented 7 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM31278 Panel.js?bust=1472165085665:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472165085665:50:15)
    at new RadioGroup (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/control/RadioGroup.js?bust=1472165085665:44:17)
    at new WOASView (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASView.js?bust=1472165085665:82:32)
    at WOASScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASScreen.js?bust=1472165085665:26:34)
    at WOASScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:134:25)
    at WOASScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:439:13)
    at http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string-main.js?bust=1472165085665:37:5
VM31278 Panel.js?bust=1472165085665:53 

>>>> sim relies on align:right
VM31278 Panel.js?bust=1472165085665:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472165085665:50:15)
    at new RadioGroup (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/control/RadioGroup.js?bust=1472165085665:44:17)
    at new WOASView (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASView.js?bust=1472165085665:90:35)
    at WOASScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASScreen.js?bust=1472165085665:26:34)
    at WOASScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:134:25)
    at WOASScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:439:13)
    at http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string-main.js?bust=1472165085665:37:5
VM31278 Panel.js?bust=1472165085665:53 

>>>> sim relies on align:right
VM31278 Panel.js?bust=1472165085665:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472165085665:50:15)
    at new RadioGroup (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/control/RadioGroup.js?bust=1472165085665:44:17)
    at new WOASView (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASView.js?bust=1472165085665:98:20)
    at WOASScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASScreen.js?bust=1472165085665:26:34)
    at WOASScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:134:25)
    at WOASScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:439:13)
    at http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string-main.js?bust=1472165085665:37:5
VM31278 Panel.js?bust=1472165085665:53 

>>>> sim relies on align:right
VM31278 Panel.js?bust=1472165085665:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472165085665:50:15)
    at new BottomControlPanel (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/control/BottomControlPanel.js?bust=1472165085665:121:26)
    at new WOASView (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASView.js?bust=1472165085665:106:20)
    at WOASScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASScreen.js?bust=1472165085665:26:34)
    at WOASScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:134:25)
    at WOASScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:439:13)
    at http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string-main.js?bust=1472165085665:37:5
VM31278 Panel.js?bust=1472165085665:53 

>>>> sim relies on align:right
VM31278 Panel.js?bust=1472165085665:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472165085665:50:15)
    at new BottomControlPanel (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/control/BottomControlPanel.js?bust=1472165085665:128:23)
    at new WOASView (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASView.js?bust=1472165085665:106:20)
    at WOASScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASScreen.js?bust=1472165085665:26:34)
    at WOASScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:134:25)
    at WOASScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:439:13)
    at http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string-main.js?bust=1472165085665:37:5
VM31278 Panel.js?bust=1472165085665:53 

>>>> sim relies on align:right
VM31278 Panel.js?bust=1472165085665:54 Error
    at new Panel (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472165085665:50:15)
    at new BottomControlPanel (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/control/BottomControlPanel.js?bust=1472165085665:135:22)
    at new WOASView (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASView.js?bust=1472165085665:106:20)
    at WOASScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string/view/WOASScreen.js?bust=1472165085665:26:34)
    at WOASScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:134:25)
    at WOASScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165085665:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165085665:439:13)
    at http://localhost/~cmalley/GitHub/wave-on-a-string/js/wave-on-a-string-main.js?bust=1472165085665:37:5
pixelzoom commented 7 years ago

None of the above call sites use the minWidth option, so their behavior will be unaffected. Closing.