search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

Emitters should have 'Emitter' suffix #126

Closed jessegreenberg closed 7 years ago

jessegreenberg commented 7 years ago

Emitters in this sim currently don't follow the convention of having ''Emitter" in the suffix of the variable name. WOASView.frame doesn't don't really look like an axon/Emitter in its usages, the suffix would help clarify.

    this.frame = new Emitter();
jessegreenberg commented 7 years ago

Done, closing.