search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

use common-code slider #132

Closed pixelzoom closed 4 years ago

pixelzoom commented 5 years ago

While working on SUN/Slider changes in https://github.com/phetsims/sun/issues/478, I discovered that wave-on-a-string has its own slider implementation WAVE_ON_A_STRING/Slider. The screenshot below shows the 2 places where it's used. This should definitely be replaced with SUN/Slider, or possibly SCENERY_PHET/NumberControl. And this is a prerequisite to a11y and phet-io instrumentation.

jonathanolson commented 4 years ago

Using NumberControl now, thanks!