search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

Does the end (window/pole/clamp) node need to be instrumented? #142

Closed jonathanolson closed 1 year ago

jonathanolson commented 4 years ago

Due to layering, the endNode does not contain the window, and it has a few different components. Can we ignore this and not instrument, or do we want to be able to hide different parts independently? That would need more integrated support.

arouinfar commented 1 year ago

We do not need to be able to hide the parts independently. In fact, it would look super strange to end the endNode altogether. I don't see any need to instrument the endNode. The important part is which end is selected, which is already covered under endTypeProperty. Closing.