search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

CT changed state on startup should be empty #143

Closed KatieWoe closed 4 years ago

KatieWoe commented 4 years ago 
wave-on-a-string : phet-io-tests : assert
7 out of 8 tests passed. 1 failed.
SimTests: wave-on-a-string: iframe api failed:
Changed state on startup should be empty, but instead includes: waveOnAString.waveOnAStringScreen.model.lastDtProperty,waveOnAString.waveOnAStringScreen.model.stepDtProperty
    at https://bayes.colorado.edu/continuous-testing/snapshot-1580786219763/phet-io-wrappers/js/tests/SimTests.js?bust=1580803225753:115:20
    at Client.dispatch (https://bayes.colorado.edu/continuous-testing/snapshot-1580786219763/phet-io-wrappers/common/js/Client.js?bust=1580803225676:432:82)
    at windowMessageListener (https://bayes.colorado.edu/continuous-testing/snapshot-1580786219763/phet-io-wrappers/common/js/Client.js?bust=1580803225676:331:24)

id: Bayes Chrome
Approximately 2/3/2020, 8:16:59 PM
wave-on-a-string : phet-io-tests : assert
7 out of 8 tests passed. 1 failed.
SimTests: wave-on-a-string: iframe api failed:
Changed state on startup should be empty, but instead includes: waveOnAString.waveOnAStringScreen.model.lastDtProperty,waveOnAString.waveOnAStringScreen.model.stepDtProperty
    at https://bayes.colorado.edu/continuous-testing/snapshot-1580786219763/phet-io-wrappers/js/tests/SimTests.js?bust=1580809867177:115:20
    at Client.dispatch (https://bayes.colorado.edu/continuous-testing/snapshot-1580786219763/phet-io-wrappers/common/js/Client.js?bust=1580809867098:432:82)
    at windowMessageListener (https://bayes.colorado.edu/continuous-testing/snapshot-1580786219763/phet-io-wrappers/common/js/Client.js?bust=1580809867098:331:24)

id: Bayes Chrome
Approximately 2/3/2020, 8:16:59 PM
wave-on-a-string : phet-io-tests : no-assert
7 out of 8 tests passed. 1 failed.
SimTests: wave-on-a-string: iframe api failed:
Changed state on startup should be empty, but instead includes: waveOnAString.waveOnAStringScreen.model.lastDtProperty,waveOnAString.waveOnAStringScreen.model.stepDtProperty
    at https://bayes.colorado.edu/continuous-testing/snapshot-1580786219763/phet-io-wrappers/js/tests/SimTests.js?bust=1580791434912:115:20
    at Client.dispatch (https://bayes.colorado.edu/continuous-testing/snapshot-1580786219763/phet-io-wrappers/common/js/Client.js?bust=1580791434803:432:82)
    at windowMessageListener (https://bayes.colorado.edu/continuous-testing/snapshot-1580786219763/phet-io-wrappers/common/js/Client.js?bust=1580791434803:331:24)

id: Bayes Chrome
Approximately 2/3/2020, 8:16:59 PM
jonathanolson commented 4 years ago

This is what I'm told is a test that needs improvement, not something that needs to be fixed in wave-on-a-string (discussed with @pixelzoom and @zepumph).

pixelzoom commented 4 years ago

This is a general problem, and wave-on-a-string is explicitly mentioned in https://github.com/phetsims/phet-io/issues/1615#issuecomment-581547877. So you could probably close this issue, unless you want to explicitly test in later in wave-on-a-string.

jonathanolson commented 4 years ago

Ahh, I looked for the issue but didn't see that it was moved! Thanks, closing.