search

phetsims / wave-on-a-string

"Wave on a String" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/wave-on-a-string
GNU General Public License v3.0
7 stars 8 forks source link

Possible to lose components in PhET-iO master iframes #144

Closed ghost closed 2 years ago

ghost commented 4 years ago

For ES6 testing.

I saw this in the text area wrapper, but I don't think it generalizes to all iframes, i.e. I tried to get this to happen on https://phet-dev.colorado.edu/html/wave-on-a-string/1.1.22-rc.1/wave-on-a-string_en-iframe.html and it didn't work.

It does, however, seem to work for Wave on a String PhET-iO wrappers on master.

issue

I'm wondering if this generalizes to other sims with similar components. I'll update the issue if it does.

Update: You can also lose the vertical ruler.

jonathanolson commented 4 years ago

Don't need an iframe, this happens just in general for the simulation (reproduced by running it locally). Should we change things so it's not possible to drag things away?

ariel-phet commented 4 years ago

@jonathanolson yes - you shouldn't be able to drag things below the nav bar in a way that you can lose them. The reference line should basically respect the nav bar as a hard boundary, and not be able to go behind it at all.

The vertical ruler probably needs to be able to be dragged down so some is behind the nav bar, but it should not be able to be lost.

jonathanolson commented 4 years ago

This should now be handled properly (and converted the sim off SimpleDragHandler). @ariel-phet does the current behavior for the rulers and reference line work well?

ariel-phet commented 2 years ago

All seems good. Closing